Modify SwitchAccount button so it doesn't overlap with Search menu in RootFilesFragment #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
overlay-transparent-button
branch
from
0d5967f to
6c7649d
Compare
KevinBoulongne
force-pushed
the
overlay-transparent-button
branch
from
6c7649d to
04a9b92
Compare
KevinBoulongne
requested changes
Mar 6, 2024
KevinBoulongne
requested changes
Mar 6, 2024
tevincent
requested changes
Mar 7, 2024
LunarX
force-pushed
the
overlay-transparent-button
branch
from
05990c0 to
9a357a6
Compare
KevinBoulongne
force-pushed
the
overlay-transparent-button
branch
from
9a357a6 to
9153dc5
Compare
…n RootFilesFragment The text below the transparent button needs to still be displayed the exact same way, so we overlay a transparent button to reduce its size independently. By limiting its size we prevent wide switch drive buttons from overlapping with the search menu from the toolbar in RootFilesFragment blocking some clicks that were aimed at the search menu button
KevinBoulongne
force-pushed
the
overlay-transparent-button
branch
from
9153dc5 to
19a2db0
Compare
KevinBoulongne
changed the title
KevinBoulongne
approved these changes
Mar 20, 2024
|
tevincent
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text below the transparent button needs to still be displayed the exact same way, so we overlay a transparent button to reduce its size independently. By limiting its size we prevent wide switch drive buttons from overlapping with the search menu from the toolbar in RootFilesFragment blocking some clicks that were aimed at the search menu button