Update API calls to receive null avatars if the users have not set any
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
added
feature
tevincent
approved these changes
Feb 29, 2024
LunarX
force-pushed
the
no-default-avatar
branch
from
d03602c to
f140ac5
Compare
LunarX
force-pushed
the
no-default-avatar
branch
from
7467abe to
33495c8
Compare
|
This PR/issue depends on:
|
LunarX
force-pushed
the
no-default-avatar
branch
from
33495c8 to
b377960
Compare
KevinBoulongne
force-pushed
the
no-default-avatar
branch
from
b377960 to
be1e7a5
Compare
KevinBoulongne
changed the title
null avatars if the users have not set any
KevinBoulongne
force-pushed
the
no-default-avatar
branch
from
91da05c to
7b28528
Compare
KevinBoulongne
approved these changes
Mar 5, 2024
LunarX
force-pushed
the
no-default-avatar
branch
from
9c4d702 to
419054d
Compare
|
tevincent
requested changes
Mar 13, 2024
tevincent
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we merge this right now, it will work for the user profile's avatar but not the others, maybe we want to wait for the kDrive api to be released even though the current api calls won't fail.
If so, make it a draft after reviewing it I guess
Edit: All is good now, we can merge.
Depends on Infomaniak/android-core#145