fix: Don't use .all { } if the list is empty, it will always return…

… `true`
Infomaniak · Feb 11, 2025 · bf14be9 · bf14be9
1 parent 8aba6c1
commit bf14be9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/app/src/main/java/com/infomaniak/drive/data/cache/DriveInfosController.kt b/app/src/main/java/com/infomaniak/drive/data/cache/DriveInfosController.kt
@@ -40,7 +40,7 @@ object DriveInfosController {
         .modules(RealmModules.DriveFilesModule())
         .build()
 
-    fun getRealmInstance() = Realm.getInstance(realmConfiguration)
+    fun getRealmInstance(): Realm = Realm.getInstance(realmConfiguration)
 
     private fun ArrayList<Drive>.initDriveForRealm(
         drive: Drive,

diff --git a/app/src/main/java/com/infomaniak/drive/ui/LaunchActivity.kt b/app/src/main/java/com/infomaniak/drive/ui/LaunchActivity.kt
@@ -128,11 +128,15 @@ class LaunchActivity : AppCompatActivity() {
             AccountUtils.updateCurrentUserAndDrives(this)
         }
 
-        val areAllDrivesInMaintenance = DriveInfosController.getDrives(userId = AccountUtils.currentUserId).all { it.maintenance }
+        val areAllDrivesInMaintenance = DriveInfosController.getDrives(userId = AccountUtils.currentUserId)
+            .takeUnless { it.isEmpty() }
+            ?.all { it.maintenance }
+            ?: false
 
-        return when {
-            areAllDrivesInMaintenance -> MaintenanceActivity::class.java
-            else -> MainActivity::class.java
+        return if (areAllDrivesInMaintenance) {
+            MaintenanceActivity::class.java
+        } else {
+            MainActivity::class.java
         }
     }