chore(DynamicDashboard): Apply suggestions

Infomaniak · Feb 24, 2025 · 78c1fd0 · 78c1fd0
1 parent 73d4953
commit 78c1fd0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/app/src/main/java/com/infomaniak/drive/data/api/ApiRepository.kt b/app/src/main/java/com/infomaniak/drive/data/api/ApiRepository.kt
@@ -45,6 +45,7 @@ import com.infomaniak.lib.core.models.ApiResponse
 import com.infomaniak.lib.core.models.ApiResponseStatus
 import com.infomaniak.lib.core.networking.HttpClient
 import okhttp3.OkHttpClient
+import com.infomaniak.core.myksuite.ui.network.ApiRoutes as MyKSuiteApiRoutes
 
 object ApiRepository : ApiRepositoryCore() {
 
@@ -512,7 +513,7 @@ object ApiRepository : ApiRepositoryCore() {
 
     fun getMyKSuiteData(okHttpClient: OkHttpClient): ApiResponse<MyKSuiteData> {
         return callApi(
-            url = com.infomaniak.core.myksuite.ui.network.ApiRoutes.myKSuiteData(),
+            url = MyKSuiteApiRoutes.myKSuiteData(),
             method = ApiController.ApiMethod.GET,
             okHttpClient = okHttpClient,
             useKotlinxSerialization = true,

diff --git a/app/src/main/java/com/infomaniak/drive/ui/MainActivity.kt b/app/src/main/java/com/infomaniak/drive/ui/MainActivity.kt
@@ -102,6 +102,7 @@ import com.infomaniak.lib.stores.updatemanagers.InAppUpdateManager
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
+import com.infomaniak.core.myksuite.R as RMyKSuite
 
 class MainActivity : BaseActivity() {
 
@@ -441,7 +442,7 @@ class MainActivity : BaseActivity() {
         }
 
         when (destination.id) {
-            R.id.fileDetailsFragment, com.infomaniak.core.myksuite.R.id.myKSuiteDashboardFragment -> {
+            R.id.fileDetailsFragment, RMyKSuite.id.myKSuiteDashboardFragment -> {
                 setColorNavigationBar(true)
             }
             R.id.fileShareLinkSettingsFragment -> {

diff --git a/app/src/main/java/com/infomaniak/drive/ui/MyKSuiteViewModel.kt b/app/src/main/java/com/infomaniak/drive/ui/MyKSuiteViewModel.kt
@@ -27,9 +27,9 @@ import kotlinx.coroutines.launch
 
 class MyKSuiteViewModel : ViewModel() {
 
-    val myKSuiteDataResult = SingleLiveEvent<MyKSuiteData?>()
+    val myKSuiteDataResult = SingleLiveEvent<MyKSuiteData>()
 
     fun refreshMyKSuite() = viewModelScope.launch(Dispatchers.IO) {
-        myKSuiteDataResult.postValue(MyKSuiteDataUtils.fetchData())
+        MyKSuiteDataUtils.fetchData()?.let(myKSuiteDataResult::postValue)
     }
 }
diff --git a/app/src/main/java/com/infomaniak/drive/ui/menu/settings/KSuiteDashboardFragment.kt b/app/src/main/java/com/infomaniak/drive/ui/menu/settings/KSuiteDashboardFragment.kt
@@ -34,8 +34,6 @@ class KSuiteDashboardFragment : MyKSuiteDashboardFragment() {
 
         myKSuiteViewModel.refreshMyKSuite()
         myKSuiteViewModel.myKSuiteDataResult.observe(viewLifecycleOwner) { myKSuiteData ->
-            if (myKSuiteData == null) return@observe
-
             resetContent(
                 dashboardData = MyKSuiteUiUtils.getDashboardData(
                     context = requireContext(),