Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(MyKSuite-09): Mark as internal concerned functions and class that doesn't need to be exposed #274

Merged
merged 1 commit into from
Feb 6, 2025
Merged

refactor(MyKSuite-09): Mark as internal concerned functions and class that doesn't need to be exposed #274

merged 1 commit into from
Feb 6, 2025

Conversation

FabianDevel
Copy link
Contributor

Depends on #273

@FabianDevel FabianDevel added the enhancement New feature or request label Feb 4, 2025
@LunarX LunarX self-requested a review February 5, 2025 08:56
LunarX
LunarX requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some classes like ExpendableActionItem should probably be internal as well.

Also your branch doesn't build because you're exposing internal classes (maybe you're missing further internal visibility modifiers?)

@FabianDevel FabianDevel force-pushed the 08-delete-KSuiteTheme branch 2 times, most recently from 65774c1 to a55c115 Compare February 5, 2025 14:23
Base automatically changed from 08-delete-KSuiteTheme to myksuite February 5, 2025 14:23
@github-actions github-actions bot removed the dependent label Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

This PR/issue depends on:

@FabianDevel FabianDevel mentioned this pull request Feb 5, 2025
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

LunarX
LunarX requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the following classes or can they be internal as well?

MyKSuiteButtonColors
MyKSuiteUpgradeFeatures

@FabianDevel FabianDevel merged commit bf336f2 into myksuite Feb 6, 2025
5 checks passed
@FabianDevel FabianDevel deleted the 09-mark-as-internal branch February 6, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@FabianDevel FabianDevel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianDevel @LunarX