Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MyKSuite-02): Upgrade bottomsheet #262

Merged
merged 13 commits into from
Feb 3, 2025
Merged

feat(MyKSuite-02): Upgrade bottomsheet #262

merged 13 commits into from
Feb 3, 2025

Conversation

FabianDevel
Copy link
Contributor

@FabianDevel FabianDevel commented Jan 28, 2025 •
edited
Loading

Depends on #261

@FabianDevel FabianDevel added the enhancement New feature or request label Jan 28, 2025
@FabianDevel FabianDevel changed the title 02 upgrade bottomsheet 02 Upgrade bottomsheet Jan 28, 2025
@FabianDevel FabianDevel changed the title 02 Upgrade bottomsheet feat(MyKSuite-02): Upgrade bottomsheet Jan 28, 2025
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from ef6a060 to e31fae9 Compare January 28, 2025 09:22
@FabianDevel FabianDevel mentioned this pull request Jan 31, 2025
Merged
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from e31fae9 to 09612c4 Compare January 31, 2025 07:33
@LunarX LunarX self-requested a review January 31, 2025 08:17
@FabianDevel FabianDevel force-pushed the 01-ksuite-chips branch 2 times, most recently from 01270b5 to 243cea5 Compare January 31, 2025 10:45
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from 09612c4 to 593082d Compare January 31, 2025 10:45
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from 593082d to b0e4242 Compare January 31, 2025 13:50
Base automatically changed from 01-ksuite-chips to myksuite January 31, 2025 14:17
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@FabianDevel
feat(MyKSuite): Really quick draft of the upgrade bottomsheet
e611dd0
@FabianDevel
chore(MyKSuite): Add banner illustrations
5e7827a 
feat(MyKSuite): Use working illustration for banner

# Conflicts:
#	MykSuite/src/main/java/com/infomaniak/lib/myksuite/ui/screens/MyKSuiteUpgradeBottomSheet.kt
@FabianDevel
feat(MyKSuite): Override material colors for the bottomsheet
6766e87
@FabianDevel
chore(MyKSuite): Add preview to the upgrade bottomsheet
0ea1de2 
# Conflicts:
#	MykSuite/src/main/java/com/infomaniak/lib/myksuite/ui/screens/MyKSuiteUpgradeBottomSheet.kt
@FabianDevel
chore(MyKSuite): Add strings
1b267c2
@FabianDevel
feat(MyKSuite): Use real strings and better UI in bottomsheet
d029fc6 
# Conflicts:
#	MykSuite/src/main/java/com/infomaniak/lib/myksuite/ui/screens/MyKSuiteUpgradeBottomSheet.kt
@FabianDevel
feat(MyKSuite): Fix colors for dark mode
f904bb3
@FabianDevel
chore(MyKSuite): Update trad
8afe5a7
@FabianDevel
feat(MyKSuite): Add MoreFeatures upgrade directly to the module
f624816
@FabianDevel
feat(MyKSuite): Wrap the component in the material theme
a786da2
@FabianDevel
refactor(MyKSuite): Add a Dimens class to factorize dimensions
fa7e7ae
@FabianDevel
refactor(MyKSuite): Extract UpgradeFeature component to its own file
d2d7116
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from b0e4242 to d2d7116 Compare January 31, 2025 14:18
LunarX
LunarX requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments

LunarX
LunarX requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments, the rest will come later

@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from ef576fe to 10864af Compare February 3, 2025 15:00
@FabianDevel FabianDevel requested a review from LunarX February 3, 2025 15:00
@FabianDevel FabianDevel force-pushed the 02-upgrade-bottomsheet branch from 10864af to 42f28c5 Compare February 3, 2025 15:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FabianDevel FabianDevel merged commit f224893 into myksuite Feb 3, 2025
5 checks passed
@FabianDevel FabianDevel deleted the 02-upgrade-bottomsheet branch February 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@FabianDevel FabianDevel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianDevel @LunarX