Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch PlayServices AppUpdate exceptions to better understand what's happening #210

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Catch PlayServices AppUpdate exceptions to better understand what's happening #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Stores/src/standard/java/com/infomaniak/lib/stores/AppUpdateScheduler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.google.common.util.concurrent.ListenableFuture
import com.infomaniak.lib.core.utils.SentryLog
import com.infomaniak.lib.stores.updatemanagers.WorkerUpdateManager
import io.sentry.Sentry
import io.sentry.SentryLevel
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
Expand Down Expand Up @@ -78,7 +79,10 @@ class AppUpdateScheduler(
updateManager.installDownloadedUpdate(
onInstallSuccess = { completer.setResult(Result.success()) },
onInstallFailure = { exception ->
Sentry.captureException(exception)
Sentry.withScope {scope ->
scope.setTag("message", exception.message ?: "Unknown error")
Sentry.captureMessage("AppUpdate throwed an exception", SentryLevel.INFO)
}
completer.setResult(Result.failure())
},
)
Expand Down
Loading