Fix missing custom interceptors and sentry interceptor in some http clients #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
fix-network-interceptors
branch
from
6d5e7e7 to
ac28263
Compare
KevinBoulongne
requested changes
May 27, 2024
src/main/java/com/infomaniak/lib/core/networking/HttpClientConfig.kt
Outdated
Show resolved
Hide resolved
|
KevinBoulongne
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now Stetho, Sentry and custom interceptors were not added in all our http clients. I factorized their addition so they are added everywhere and so we will be less likely to forget to add them if we ever create a new http client elsewhere