Clean code

Infomaniak · Feb 6, 2024 · c588718 · c588718
1 parent 0dc59aa
commit c588718
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Stores/src/main/java/StoresLocalSettings.kt b/Stores/src/main/java/StoresLocalSettings.kt
@@ -26,7 +26,7 @@ class StoresLocalSettings private constructor(context: Context) : SharedValues {
     override val sharedPreferences = context.applicationContext.getSharedPreferences(SHARED_PREFS_NAME, Context.MODE_PRIVATE)!!
 
     var isUserWantingUpdates by sharedValue("isUserWantingUpdatesKey", true)
-    var hasAppUpdateDownloaded by sharedValue("hasAppUpdateDownloaded", false)
+    var hasAppUpdateDownloaded by sharedValue("hasAppUpdateDownloadedKey", false)
     var appUpdateLaunches by sharedValue("appUpdateLaunchesKey", 0)
     var appReviewLaunches by sharedValue("appReviewLaunchesKey", DEFAULT_APP_REVIEW_LAUNCHES)
     var showAppReviewDialog by sharedValue("showAppReviewDialogKey", true)
@@ -40,10 +40,10 @@ class StoresLocalSettings private constructor(context: Context) : SharedValues {
 
     companion object {
 
-        private const val SHARED_PREFS_NAME = "StoresLocalSettingsSharedPref"
-
         const val DEFAULT_APP_REVIEW_LAUNCHES = 50
 
+        private const val SHARED_PREFS_NAME = "StoresLocalSettingsSharedPref"
+
         @Volatile
         private var INSTANCE: StoresLocalSettings? = null
 

diff --git a/Stores/src/standard/java/com.infomaniak.lib.stores/InAppUpdateManager.kt b/Stores/src/standard/java/com.infomaniak.lib.stores/InAppUpdateManager.kt
@@ -44,7 +44,7 @@ class InAppUpdateManager(
 
     private val appUpdateManager = AppUpdateManagerFactory.create(activity)
     // Result of in app update's bottomSheet user choice
-    private var inAppUpdateResultLauncher: ActivityResultLauncher<IntentSenderRequest> = activity.registerForActivityResult(
+    private val inAppUpdateResultLauncher: ActivityResultLauncher<IntentSenderRequest> = activity.registerForActivityResult(
         ActivityResultContracts.StartIntentSenderForResult()
     ) { result ->
         val isUserWantingUpdate = result.resultCode == AppCompatActivity.RESULT_OK
@@ -118,7 +118,7 @@ class InAppUpdateManager(
     }
 
     private fun observeAppUpdateDownload() {
-        viewModel.canInstallUpdate.observe(activity) { isUploadDownloaded -> onInAppUpdateUiChange?.invoke(isUploadDownloaded) }
+        viewModel.canInstallUpdate.observe(activity) { isUpdateDownloaded -> onInAppUpdateUiChange?.invoke(isUpdateDownloaded) }
     }
 
     private fun checkStalledUpdate(): Unit = with(appUpdateManager) {