chore(MyKSuiteChip): Add dark preview and remove click listener

Infomaniak · Jan 27, 2025 · 92b2229 · 92b2229
1 parent fade8f9
commit 92b2229
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/MykSuite/src/main/java/com/infomaniak/lib/myksuite/ui/components/MyKSuiteChips.kt b/MykSuite/src/main/java/com/infomaniak/lib/myksuite/ui/components/MyKSuiteChips.kt
@@ -17,8 +17,11 @@
  */
 package com.infomaniak.lib.myksuite.ui.components
 
+import android.content.res.Configuration
 import androidx.compose.foundation.Image
 import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.SuggestionChip
 import androidx.compose.material3.SuggestionChipDefaults
 import androidx.compose.material3.Surface
@@ -27,48 +30,50 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.res.vectorResource
 import androidx.compose.ui.tooling.preview.Preview
+import androidx.compose.ui.unit.dp
 import com.infomaniak.lib.myksuite.R
+import com.infomaniak.lib.myksuite.ui.theme.Margin
 import com.infomaniak.lib.myksuite.ui.theme.MyKSuiteTheme
 
 @Composable
-fun MyKSuitePlusChip(modifier: Modifier = Modifier, onClick: () -> Unit) {
+fun MyKSuitePlusChip(modifier: Modifier = Modifier) {
     Chip(
         modifier = modifier,
-        onClick = onClick,
         label = { Image(ImageVector.vectorResource(R.drawable.ic_logo_my_ksuite_plus), contentDescription = "My kSuite +") },
     )
 }
 
 @Composable
-fun MyKSuiteChip(modifier: Modifier = Modifier, onClick: () -> Unit) {
+fun MyKSuiteChip(modifier: Modifier = Modifier) {
     Chip(
         modifier = modifier,
-        onClick = onClick,
         label = { Image(ImageVector.vectorResource(R.drawable.ic_logo_my_ksuite), contentDescription = "My kSuite") },
     )
 }
 
 @Composable
-private fun Chip(modifier: Modifier = Modifier, onClick: () -> Unit, label: @Composable () -> Unit) {
+private fun Chip(modifier: Modifier = Modifier, label: @Composable () -> Unit, onClick: () -> Unit = {}) {
     SuggestionChip(
         modifier = modifier,
         onClick = onClick,
         label = label,
         border = null,
+        shape = RoundedCornerShape(Margin.Medium),
         colors = SuggestionChipDefaults.suggestionChipColors(
             containerColor = MyKSuiteTheme.colors.chipBackground,
         ),
     )
 }
 
-@Preview
+@Preview(name = "(1) Light")
+@Preview(name = "(2) Dark", uiMode = Configuration.UI_MODE_NIGHT_YES or Configuration.UI_MODE_TYPE_NORMAL)
 @Composable
 private fun Preview() {
     MyKSuiteTheme {
         Surface {
             Column {
-                MyKSuitePlusChip {}
-                MyKSuiteChip {}
+                MyKSuitePlusChip()
+                MyKSuiteChip()
             }
         }
     }