Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open to NewTransferActivity if a transfer is in progress #434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TommyDL-Infomaniak
Copy link
Contributor

No description provided.

@TommyDL-Infomaniak TommyDL-Infomaniak added enhancement New feature or request quick A pull request consisting of a few lines labels Feb 25, 2025
@TommyDL-Infomaniak TommyDL-Infomaniak requested a review from a team February 25, 2025 08:15
@TommyDL-Infomaniak TommyDL-Infomaniak self-assigned this Feb 25, 2025

return Intent(intent).apply {
setClass(this@LaunchActivity, NewTransferActivity::class.java)
putExtra(NOTIFICATION_NAVIGATION_KEY, NotificationNavigation.UploadProgress.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used only if we're coming from a notification, right ? It's a bit weird to use the same key.


// We need NewMessageActivity to have its standard launchMode in the Manifest
// in order for FLAG_ACTIVITY_CLEAR_TOP to kill and recreate NewMessageActivity
flags = Intent.FLAG_ACTIVITY_CLEAR_TOP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're go back to the ongoing transfer and this one is finished, we should see the result screen right ?

@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quick A pull request consisting of a few lines rebase Add this label to rebase the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants