feat: Split app integrity logic from send transfer logic #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
requested changes
Dec 19, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt
Outdated
Show resolved
Hide resolved
FabianDevel
requested changes
Dec 20, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
extract-app-integrity-logic
branch
from
12de30c to
13d6757
Compare
FabianDevel
requested changes
Dec 20, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/TransferSendManager.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
extract-app-integrity-logic
branch
from
c8a083d to
5803eed
Compare
FabianDevel
approved these changes
Dec 20, 2024
KevinBoulongne
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Ok for me, the runCatching issues are already fixed in #278.
…a Kotlin DSL method
LunarX
force-pushed
the
extract-app-integrity-logic
branch
from
5803eed to
d30acb2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll later need to call two different logics with an integrity token so I refactored the code to be able to easily reuse the integrity token for any purpose