Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update logos #253

Merged
merged 2 commits into from
Dec 16, 2024
Merged

feat: Update logos #253

merged 2 commits into from
Dec 16, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Dec 13, 2024

This PR adds the correct launcher icon and notification icon. The splashscreen icon is still missing and we're waiting for it

@LunarX LunarX added enhancement New feature or request quick A pull request consisting of a few lines labels Dec 13, 2024
@LunarX LunarX requested a review from a team December 13, 2024 14:32
@LunarX LunarX self-assigned this Dec 13, 2024
@LunarX LunarX changed the title feat: Update logo feat: Update logos Dec 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LunarX LunarX marked this pull request as ready for review December 16, 2024 08:06
tevincent
tevincent requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tevincent tevincent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a k in the icon right ?

Capture d’écran 2024-12-16 à 11 01 53 Capture d’écran 2024-12-16 à 11 02 53

It seems to be a design limitation.

@LunarX LunarX merged commit 2c417e0 into main Dec 16, 2024
9 checks passed
@LunarX LunarX deleted the update-logo branch December 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevincent tevincent tevincent approved these changes

Assignees

@LunarX LunarX

Labels
enhancement New feature or request quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LunarX @tevincent