feat: Handle prepod Deeplink #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tevincent
requested changes
Dec 11, 2024
tevincent
requested changes
Dec 12, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersViewModel.kt
Outdated
Show resolved
Hide resolved
tevincent
requested changes
Dec 16, 2024
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersScreenWrapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersViewModel.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Dec 16, 2024
...java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersScreenWrapper.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Dec 16, 2024
FabianDevel
requested changes
Dec 17, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/components/MainScaffold.kt
Outdated
Show resolved
Hide resolved
| val currentBackStackEntry = [email protected] | ||
| val hasDeepLink = currentBackStackEntry?.arguments?.parcelableExtra<Intent>(NavController.KEY_DEEP_LINK_INTENT) != null | ||
| val isNavigateToStartDestination = startDestination.route == destination::class.qualifiedName | ||
| restoreState = !hasDeepLink || !isNavigateToStartDestination |
There was a problem hiding this comment.
This break the Ui of the "sent" destination by creating a huge blink as Sentis the startDestination
...java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
...java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDetailsViewModel.kt
Show resolved
Hide resolved
…plink from bottombar
Those are needed only if the given lambda reads another state. It wasn't the case here, hence the removal. This commit also introduces a single-use private function that helps clarify that we want to show navigation while we're in a top-level destination.
This simplifies the code a little bit, and saves a few CPU cycles.
Co-authored-by: Fabian Devel <[email protected]>
Co-authored-by: Fabian Devel <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.