feat: Add password popup #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
force-pushed
the
add-password-popup
branch
from
10e6f01 to
1d3cde8
Compare
FabianDevel
force-pushed
the
add-advancedOption-buttons-states
branch
from
7f8a493 to
72ea3d0
Compare
FabianDevel
force-pushed
the
add-password-popup
branch
from
1d3cde8 to
6aef2f8
Compare
tevincent
requested changes
Nov 5, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferAlertDialog.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferViewModel.kt
Outdated
Show resolved
Hide resolved
...niak/swisstransfer/ui/screen/newtransfer/importfiles/components/PasswordOptionAlertDialog.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
add-advancedOption-buttons-states
branch
from
72ea3d0 to
5513e9a
Compare
FabianDevel
force-pushed
the
add-password-popup
branch
3 times, most recently
from
37ca98e to
f137f7e
Compare
FabianDevel
force-pushed
the
add-password-popup
branch
from
f137f7e to
3c02ea1
Compare
tevincent
approved these changes
Nov 7, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferViewModel.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
add-advancedOption-buttons-states
branch
from
27f9d74 to
2610fcb
Compare
FabianDevel
force-pushed
the
add-password-popup
branch
from
da16068 to
d1b9e28
Compare
LunarX
reviewed
Nov 7, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferViewModel.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
add-advancedOption-buttons-states
branch
from
2610fcb to
32adcd8
Compare
LunarX
requested changes
Nov 7, 2024
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Show resolved
Hide resolved
LunarX
reviewed
Nov 7, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferViewModel.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
add-password-popup
branch
from
d1b9e28 to
46d8050
Compare
|
This PR/issue depends on:
|
FabianDevel
force-pushed
the
add-password-popup
branch
from
46d8050 to
2385da2
Compare
KevinBoulongne
requested changes
Nov 8, 2024
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt
Show resolved
Hide resolved
KevinBoulongne
requested changes
Nov 8, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferAlertDialog.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferTextField.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
add-password-popup
branch
2 times, most recently
from
66d073e to
0ad77b1
Compare
LunarX
approved these changes
Nov 11, 2024
KevinBoulongne
force-pushed
the
add-password-popup
branch
from
0ad77b1 to
cbd34d2
Compare
KevinBoulongne
approved these changes
Nov 11, 2024
…ssTransferAlertDialog
…assword isn't valid Doesn't display error when the field is empty
…he PasswordAlert component
…nitialization in the viewModel
…tead of collecting flow
…in a single composable
FabianDevel
force-pushed
the
add-password-popup
branch
from
cbd34d2 to
5e4c419
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #144
Add the password option that was left out of the #144 PR