From 1eb57843650a3b82cdf6a6f7ce96c641f061c4d4 Mon Sep 17 00:00:00 2001 From: Kevin Boulongne Date: Thu, 31 Oct 2024 14:19:09 +0100 Subject: [PATCH] review: Clean code --- .../swisstransfer/ui/components/FileItem.kt | 2 +- .../ui/components/transfer/TransferItem.kt | 12 +++--------- .../ui/components/transfer/TransferItemList.kt | 10 ++-------- 3 files changed, 6 insertions(+), 18 deletions(-) diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt index 2dd359d189..28ba580c0d 100644 --- a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt +++ b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt @@ -84,7 +84,7 @@ private fun FileItemContent( ) { Box( modifier = Modifier - .weight(1f) + .weight(1.0f) .fillMaxWidth() .background(SwissTransferTheme.materialColors.surfaceContainerHighest) ) { diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItem.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItem.kt index 30e4ee6813..e17c3cccc5 100644 --- a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItem.kt +++ b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItem.kt @@ -44,10 +44,7 @@ import java.util.UUID @OptIn(ExperimentalLayoutApi::class) @Composable -fun TransferItem( - transfer: TransferUi, - onClick: () -> Unit, -) { +fun TransferItem(transfer: TransferUi, onClick: () -> Unit) { Card( onClick = onClick, colors = CardDefaults.cardColors(containerColor = SwissTransferTheme.materialColors.surfaceContainerHighest), @@ -58,9 +55,7 @@ fun TransferItem( verticalAlignment = Alignment.CenterVertically, ) { - Column( - modifier = Modifier.weight(1.0f), - ) { + Column(modifier = Modifier.weight(1.0f)) { Text( text = Date(transfer.createdDateTimestamp).format(FORMAT_DATE_TITLE), @@ -159,8 +154,7 @@ private fun Preview() { localPath = null, ), ), - - ), + ), onClick = {}, ) } diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt index 2f3faf1c7e..8b5bb60bb3 100644 --- a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt +++ b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt @@ -61,10 +61,7 @@ fun TransferItemList( contentType = { transfers[it] }, itemContent = { val transfer = transfers[it] - TransferItem( - transfer = transfer, - onClick = { onClick(transfer) }, - ) + TransferItem(transfer) { onClick(transfer) } }, ) } @@ -163,10 +160,7 @@ private fun Preview() { SwissTransferTheme { Surface { - TransferItemList( - transfers = transfers, - onClick = {}, - ) + TransferItemList(transfers = transfers, onClick = {}) } } }