Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a half-press gesture to perform a click #1487

Closed
javifernandez opened this issue Jul 24, 2024 · 2 comments · Fixed by #1678
Closed

Use a half-press gesture to perform a click #1487

javifernandez opened this issue Jul 24, 2024 · 2 comments · Fixed by #1678
Labels
enhancement New feature or request feedback-form priority-medium

Comments

@javifernandez
Copy link
Member

javifernandez commented Jul 24, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
I have to fully press down on the primary trigger with my meta quest 3 controllers in order to press a button or key. This is slow, causes me to miss button presses.

Describe the solution you'd like
A clear and concise description of what you want to happen.
In contrast to the Oculus browser where I only have to press halfway.

Describe alternatives you've considered

Additional context
@javifernandez javifernandez added enhancement New feature or request feedback-form labels Jul 24, 2024
@svillar
Copy link
Member

svillar commented Jul 30, 2024

I don't think we are changing anything here. The actual threshold we use to consider a press as a click is 91% and it has been working fine for most if not all devices. Changing that to a lower value would result in tons of new unsolicited click and/or drag events.

@javifernandez
Copy link
Member Author

If you compare with the browser shipped by Meta, the pressure level is considerable lower there.

svillar added a commit that referenced this issue Jan 14, 2025
@svillar
Reduce sensitivity required by controller trigger
fd37627 
We've been traditionally using a high value for clicking threshold
(0.91) in order not to generate false positives specially when using
hand tracking. However, that does not make much sense when using
physical controllers because they're very precise and false positives
are not a real problem there.

We can actually lower it to just 25% of the full pressed position
without any accuracy loss, and indeed, the experience is much
better. It's also good for a11y.

Fixes #1487
@svillar svillar mentioned this issue Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feedback-form priority-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce sensitivity required by controller trigger Igalia/wolvic
3 participants
@juanjosanchez @svillar @javifernandez