Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming dplyr / sf combination breaks GADMTools on CRAN #1

Closed
edzer opened this issue Mar 21, 2020 · 0 comments
Closed

upcoming dplyr / sf combination breaks GADMTools on CRAN #1

edzer opened this issue Mar 21, 2020 · 0 comments

Comments

@edzer
Copy link

edzer commented Mar 21, 2020

You probably got an email from rstudio, warning that the new dplyr breaks GADMTools; the reason for this is that dplyr no longer accepts sf objects as second argument in left_join; it breaks here:

.sf_data <- dplyr::left_join(.sf_data, .map) %>%

What you want to do is revert the arguments, e.g. use right_join(.map, .sf_data) so that right_join.sf is being called, and that takes care of dplyr's problems with sf objects. For you to check that right_join is the right thing to call. See also r-spatial/sf#1310 ; I ran into this because GADMTools broke in a revdep check for upcoming sf, but that turned out to be my, not your problem (and now solved); checking with new dplyr revealed this one.

@IamKDO IamKDO closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants