-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 이벤트 API 기능 추가 #79
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 리뷰 확인바랍니다 :D
@PatchMapping(value = "/{id}", consumes = { MediaType.MULTIPART_FORM_DATA_VALUE }) | ||
public ResponseEntity<ApiResponse<EventResponseDto>> updateEvent( | ||
@PathVariable Long id, | ||
@RequestPart(value = "eventUpdateRequest") EventUpdateRequestDto request, // JSON을 받기 위해 @RequestPart로 변경 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이벤트 삭제 API도 등록 해주실 수 있을까요?
/** | ||
* EventStatistics의 bookmarkCount 증가 | ||
*/ | ||
eventStatisticsRepository.findByCommonEventId(commonPlace.getId()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -42,11 +46,21 @@ public EventResponseDto createUserEvent(EventRequestDto request, Long userId) { | |||
return userEventConverter.toResponse(userEvent); | |||
} | |||
|
|||
public EventResponseDto updateEvent(Long id, EventUpdateRequestDto request) { | |||
public EventResponseDto updateEvent(Long id, EventUpdateRequestDto request, MultipartFile newImage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 회의 내용 기반으로 기능이 수정되어서 이제 이벤트에 여러개의 이미지가 등록될 수 있습니다! 아무래도 List<MultipartFile> newImageList
형식으로 수정이 필요할거 같아요. 그리고 매개 변수 변경에 따라 updateImage도 List를 이용해서 순차적으로 업데이트 되도록 변경해야할 거 같습니다! 기존의 uploadImage 로직을 참고해주세요!
💡 작업 내용
💡 자세한 설명
(가능한 한 자세히 작성해 주시면 도움이 됩니다.)
📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
✅ 셀프 체크리스트