Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG - WP and HOLD pins are configured wrong #21

Open
TjazVracko opened this issue Sep 21, 2023 · 0 comments
Open

BUG - WP and HOLD pins are configured wrong #21

TjazVracko opened this issue Sep 21, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TjazVracko
Copy link
Contributor

The configuration of the WP and HOLD pins in the driver initialization is wrong.
The pins should be configured to OUTPUT_INACTIVE since the pins are logically inverted (WPn and HOLDn)

The DTS for the flash entry should also be specified as GPIO_ACTIVE_LOW, not as 0, as it is now.

This and the readme have to be updated.
@TjazVracko TjazVracko added bug Something isn't working good first issue Good for newcomers labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TjazVracko