Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing no mappings at all will result in validation success #113

Open
matentzn opened this issue Oct 2, 2020 · 1 comment
Open

Doing no mappings at all will result in validation success #113

matentzn opened this issue Oct 2, 2020 · 1 comment

Comments

@matentzn
Copy link
Collaborator

matentzn commented Oct 2, 2020

Minor, just so its documented. But users could, in principle, submit an entirely unmapped data dictionary. Maybe thats fine, its definitely not a priority.

@beckyjackson
Copy link
Collaborator

I don't think an unmapped dictionary should ever pass validation. That said, it may turn out that a cohort has a few unmapped terms that don't fit the GECKO model and that's OK... although in this case, we should encourage them to submit their unmapped terms to GECKO and see if we can fit them in.

Maybe we should require a certain percentage of the data dictionary to be mapped in order to submit? 50%?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants