Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image preview doesn't close on clicking left side of screen in desktop mode #24

Open
aldrinjenson opened this issue Sep 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@aldrinjenson
Copy link
Member

image

Right now if we click on an image in desktop mode, it opens up in a modal sort of way as shown in the above screenshot. Clicking on the image or on the right side of it closes the modal and reverts back to normal mode but clicking on the left doesn't close it leading to some users identifying it as a bug.
See if you can change it such that when clicking on the left side also, the modal is closed.

Possible Mentor: @alanphil2k01

@aldrinjenson aldrinjenson added the bug Something isn't working label Sep 2, 2022
@jaison080
Copy link
Member

Ig its an issue with the theme since its divided into two portions one the main logo and the other is the post content. Since the image is opened from the post side we have to click on the post side to close it.

@aldrinjenson
Copy link
Member Author

Ahh okay. Couldn't see any issues related to this one in the anatole github.
Maybe it's possible to do some inspect element trick and have a transparent background which when clicked adds the same css to close the image. Or Ig if there's more demand for this feature (of being able to close the modal from either sides) to be implemented in our blog, we could try raising a new issue with anatole and see their response.
Let's keep the issue open in case anyone has some clever hacks/suggestions/more demand for the feature.

@jaison080
Copy link
Member

Yeah okay. .👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants