From 58086e59507d04bdd00cdff907833b03adff396a Mon Sep 17 00:00:00 2001 From: dafnapension Date: Sun, 19 Jan 2025 16:43:11 +0200 Subject: [PATCH 1/2] fixed division by 0 in compare performance results Signed-off-by: dafnapension --- .../compare_benchmark_performance_results.py | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/performance/compare_benchmark_performance_results.py b/performance/compare_benchmark_performance_results.py index 7b934c528e..280d082c4e 100644 --- a/performance/compare_benchmark_performance_results.py +++ b/performance/compare_benchmark_performance_results.py @@ -26,11 +26,23 @@ print(f"use Mocked inference = {os.environ['UNITXT_MOCK_INFERENCE_MODE']}") ratio1 = ( - pr_perf["generate_benchmark_dataset_time"] - pr_perf["load_time_no_initial_ms"] -) / ( - main_perf["generate_benchmark_dataset_time"] - main_perf["load_time_no_initial_ms"] + (pr_perf["generate_benchmark_dataset_time"] - pr_perf["load_time_no_initial_ms"]) + / ( + main_perf["generate_benchmark_dataset_time"] + - main_perf["load_time_no_initial_ms"] + ) + if ( + main_perf["generate_benchmark_dataset_time"] + - main_perf["load_time_no_initial_ms"] + ) + > 0 + else 1 +) +ratio2 = ( + pr_perf["evaluation_time"] / main_perf["evaluation_time"] + if main_perf["evaluation_time"] > 0 + else 1 ) -ratio2 = pr_perf["evaluation_time"] / main_perf["evaluation_time"] # Markdown table formatting line1 = " What is Measured | Main Branch | PR Branch | PR/Main ratio \n" From b6252d51cc08d5029a0c0060da589a25662c79d3 Mon Sep 17 00:00:00 2001 From: dafnapension Date: Sun, 19 Jan 2025 17:19:02 +0200 Subject: [PATCH 2/2] fixed another zero division Signed-off-by: dafnapension --- performance/compare_benchmark_performance_results.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/performance/compare_benchmark_performance_results.py b/performance/compare_benchmark_performance_results.py index 280d082c4e..7122b55e05 100644 --- a/performance/compare_benchmark_performance_results.py +++ b/performance/compare_benchmark_performance_results.py @@ -48,7 +48,12 @@ line1 = " What is Measured | Main Branch | PR Branch | PR/Main ratio \n" line2 = "--------------------|-------------|-------------|---------------\n" line3 = f" Total time | {main_perf['total_time']:>11} | {pr_perf['total_time']:>11} | {pr_perf['total_time']/main_perf['total_time']:.2f}\n" -line4 = f" Load time | {main_perf['load_time_no_initial_ms']:>11} | {pr_perf['load_time_no_initial_ms']:>11} | {pr_perf['load_time_no_initial_ms']/main_perf['load_time_no_initial_ms']:.2f}\n" +ratio_line4 = ( + pr_perf["load_time_no_initial_ms"] / main_perf["load_time_no_initial_ms"] + if main_perf["load_time_no_initial_ms"] > 0 + else 1 +) +line4 = f" Load time | {main_perf['load_time_no_initial_ms']:>11} | {pr_perf['load_time_no_initial_ms']:>11} | {ratio_line4:.2f}\n" line5 = f" DS Gen. inc. Load | {main_perf['generate_benchmark_dataset_time']:>11} | {pr_perf['generate_benchmark_dataset_time']:>11} | {pr_perf['generate_benchmark_dataset_time']/main_perf['generate_benchmark_dataset_time']:.2f}\n" line6 = f" DS Gen. exc. Load | {round(main_perf['generate_benchmark_dataset_time']-main_perf['load_time_no_initial_ms'], 3):>11} | {round(pr_perf['generate_benchmark_dataset_time']-pr_perf['load_time_no_initial_ms'], 3):>11} | {ratio1:.2f}\n" line7 = f" Inference time | {main_perf['inference_time']:>11} | {pr_perf['inference_time']:>11} | {pr_perf['inference_time']/main_perf['inference_time']:.2f}\n"