Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding padding at the input when necessary #342

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Adding padding at the input when necessary #342

wants to merge 28 commits into from

Conversation

Joao-L-S-Almeida
Copy link
Member

  • Should we add negative padding ? Could we remove some lines/rows instead of adding multiple lines/rows of zeroes ?
  • Are we interested in choosing the kind of padding or 'constant' is good enough ?

@Joao-L-S-Almeida
Adding padding at the input when necessary
842941b 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Dec 23, 2024
@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Dec 23, 2024 that may be closed by this pull request
Add padding while evaluating on the original mask size #261
Open
@Joao-L-S-Almeida Joao-L-S-Almeida mentioned this pull request Dec 23, 2024
Open
@Joao-L-S-Almeida
patch_size as a explicit argument for PixelWiseModel
6528861 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
logging
8376a5e 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Cropping image
8fa3bba 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
cropping image for scaler model
6fb8c95 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
patch_size could be None
5f37ba7 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Adapting the Clay factory to support patch_size and minor adjusts
5cb27dc 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Trying to reduce the cost of these tests
ba43134 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
pad_images must be in utils.py
9c26eab 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida Joao-L-S-Almeida marked this pull request as ready for review January 3, 2025 18:26
@Joao-L-S-Almeida Joao-L-S-Almeida changed the title [WIP] Adding padding at the input when necessary Adding padding at the input when necessary Jan 3, 2025
blumenstiel
blumenstiel reviewed Jan 6, 2025
View reviewed changes
tests/resources/configs/manufactured-finetune_prithvi_swin_L.yaml
- class_path: albumentations.HorizontalFlip
init_args:
p: 0.5
- class_path: albumentations.Rotate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use albumentations.D4 instead of HorizontalFlip and Rotate.

@Joao-L-S-Almeida
Cropping images could be a necessary operation
c4fd736 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
The cropping must be placed before the head in case of scalar models
b70a368 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Creating extra images for tests
ecca3aa 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Minor changes
e09cd79 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
img_size also could be necessary
6fdf1b7 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
conditional cropping
6178b47 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
config for testing nondivisible images
8cb6d26 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
minor adjusts
cb62e56 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
minor adjusts
a0cac1c 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Input files to be used for testing the padding for non-divisible images
ca881b4 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
minor changes
62fa305 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
more tests
1c409e8 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
0d79f8e 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
42c3d98 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
fd1599f 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
41af8f7 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
dde31bb 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
argument not used
e04e53e 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
merging
8cb2ff9 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blumenstiel blumenstiel blumenstiel left review comments

@romeokienzler romeokienzler Awaiting requested review from romeokienzler

At least 1 approving review is required to merge this pull request.

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add padding while evaluating on the original mask size
2 participants
@Joao-L-S-Almeida @blumenstiel