Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a proper commander migration to version 13.0.0 #795

Open
eiri opened this issue Jan 6, 2025 · 0 comments
Open

fix: a proper commander migration to version 13.0.0 #795

eiri opened this issue Jan 6, 2025 · 0 comments

Comments

@eiri
Copy link
Member

eiri commented Jan 6, 2025

The version 13.0.0 of commander introduced a breaking change on excess of command-arguments. #793

Our CI was failing with error: too many arguments. Expected 0 arguments but got 1 in parseRestoreArgs, but a reason for that is not clear. For now I just set allowExcessArguments() on the parser to revert to the former behaviour, but if possible it would be proper to find out the root cause for the failure and properly fix it, probably by listing expected arguments on parser call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant