Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn example into single action #4

Open
kalantar opened this issue Feb 22, 2022 · 0 comments
Open

turn example into single action #4

kalantar opened this issue Feb 22, 2022 · 0 comments

Comments

@kalantar
Copy link

I am confused by why this is called an action. This seems to be a sample workflow that shows what steps are needed to do a login/cluster config. Why not replace all of it with an action that hides this from the user. Use would be a single step; something like:

    - uses: kalantar/iks@main
      with:
        IBM_CLOUD_API_KEY: ${{ secrets.IBM_CLOUD_API_KEY }}
        IBM_CLOUD_RESOURCE_GROUP: <fill in>
        IBM_CLOUD_REGION: <fill in>
        IKS_CLUSTER: <fill in>

As an example, I created https://github.com/kalantar/iks. However, I am not very familiar with the login process and do not know if there are other cases/inputs that should be handled by such an action. Or if there are suitable defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant