Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid default value for UspNatV1Field.MSPA_COVERED_TRANSACTION? #29

Open
matt-martin opened this issue Jul 6, 2023 · 1 comment
Open

Comments

@matt-martin
Copy link

matt-martin commented Jul 6, 2023

The specification says that the valid values for MspaCoveredTransaction are:

1 Yes
2 No

But this field is given a default value of 0 here:

fields.put(UspNatV1Field.MSPA_COVERED_TRANSACTION, new EncodableFixedInteger(2, 0));

Should the spec be updated to say that 0 is valid? Or would it make sense to use a different default in the code?

@patmmccann
Copy link

0 is invalid; the code here is wrong

iabmayank pushed a commit that referenced this issue Aug 30, 2023
* #29
#26

* Removes duplicate section in the GppModel.decodeSection

* Rename multistate usp* to us*

* fix tcfcav1 policy version

* vendor list 2.2

* lazy decoding

* cleanup lazy decoding

* Updating GVL code as V3 and adding some comments; also removing GPPModel LazyDecoding feature; also keeping the TCF policy version as 2 for Canada.

* 3.1.0

* 3.1.1-SNAPSHOT

---------

Co-authored-by: chad <[email protected]>
Co-authored-by: srini81 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants