Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found vulnerabilities in some requirements in BalanceState.sol and LiquidStaking.sol #14

Closed
Vitomir2 opened this issue May 9, 2024 · 0 comments · Fixed by #15
Closed

Found vulnerabilities in some requirements in BalanceState.sol and LiquidStaking.sol #14

Vitomir2 opened this issue May 9, 2024 · 0 comments · Fixed by #15
Assignees
@Vitomir2

Comments

@Vitomir2
Copy link
Contributor

Vitomir2 commented May 9, 2024 •
edited
Loading

In the _mint and _burn functions, in the BalanceState.sol, we are requiring the msg.sender to not be a zero address, while it is nearly impossible. It is correct to require the account param to not be the zero address.

Additionally, in the _collectTokens function, in the LiquidStaking.sol, we check the liquidDebt of the msg.sender instead of the staker.
@Vitomir2 Vitomir2 self-assigned this May 9, 2024
@Vitomir2 Vitomir2 linked a pull request May 14, 2024 that will close this issue
use address parameters instead of msg.sender #15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vitomir2 Vitomir2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use address parameters instead of msg.sender Hydra-Chain/hydragon-core-contracts
1 participant
@Vitomir2