[email protected] does not disable tkinter on gnu+linux

[ipatch]

brew gist-logs <formula> link OR brew config AND brew doctor output

na

Verification

• My brew doctor output says Your system is ready to brew. and am still able to reproduce my issue.
• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.
• I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

with my homebrew install on arch linux i run homebrew in a non standard prefix ie. ~/homebrew that said, i believe this issue could effect standard prefix installations of homebrew as well.

What happened (include all command output)?

running brew install [email protected] -v -s will fail.

i think the homebrew ci is able to produce a working bottle because it sets up a fresh homebrew installation to where tcl-tk is not installed in the environment. that said if someone has explicitly installed tcl-tk and then installs [email protected] from source the configure script for python will pick up on the tcl-tk install in the path and attempt to configure [email protected] with tcl-tk support thus running into the tkinter build / linking error.

in the [email protected] formula file there is the below snippet,

 # Disabled modules - provided in separate formulae
    args += %w[
      py_cv_module__tkinter=disabled
    ]

homebrew-core/Formula/p/[email protected]

Lines 189 to 193 in a82002a

	# Disabled modules - provided in separate formulae
	args += %w[
	py_cv_module__tkinter=disabled
	]

that snippet essentially does nothing. one can verify by running the below command,

note: tcl-tk should be installed, ie. brew install tcl-tk

run,

brew install --interactive -v [email protected] -s

open up the config.log do a search for tkinter and notice the values set within the config.log

---

i ended up using the same technique that macports uses for disabling tcl-tk ie. seen below,

https://github.com/Homebrew/homebrew-core/blob/5024d5b785db171580f43ce223e0eb6a3b6a0c45/patches/python-3.12-disable-tkinter.patch

What did you expect to happen?

a working python installation, ie. a configure build link of python without failure.

Step-by-step reproduction instructions (by running brew commands)

previously mentioned

[Bo98]

Does n/a work instead of disabled?

[ipatch]

Does n/a work instead of disabled?

hunh? 🤨

[cho-m]

Does n/a work instead of disabled?

Should work.

---

Alternatively/Additionally could always set PKG_CONFIG_LIBDIR on Linux to ignore the default path, e.g.

$ pkg-config tcl --path
/home/linuxbrew/.linuxbrew/lib/pkgconfig/tcl.pc

$ PKG_CONFIG_LIBDIR= pkg-config tcl --path

$ PKG_CONFIG_LIBDIR= PKG_CONFIG_PATH=/home/linuxbrew/.linuxbrew/opt/tcl-tk/lib/pkgconfig pkg-config tcl --path
/home/linuxbrew/.linuxbrew/opt/tcl-tk/lib/pkgconfig/tcl.pc

We do already set this environment variable on macOS, which may be why we experience less opportunistic linkage compared to Linux.

[cho-m]

Alternatively/Additionally could always set PKG_CONFIG_LIBDIR on Linux to ignore the default path

Added this to brew in Homebrew/brew#19023. Works for me to prevent unexpected detection of both tcl-tk and util-linux.

Note that some formulae may need to be rebuilt to drop opportunistic linkage (e.g. saw this for freetype when built with brotli already installed).

[cho-m]

Adding n/a in #203210, which should ignore all TCL/Tk detection.