Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CV] Request new entry: base peak intensity maximum #246

Open
julianu opened this issue Dec 3, 2024 · 4 comments
Open

[CV] Request new entry: base peak intensity maximum #246

julianu opened this issue Dec 3, 2024 · 4 comments
Labels

Comments

@julianu
Copy link
Collaborator

julianu commented Dec 3, 2024

What is the QC term's name?

base peak intensity maximum

Briefly describe the QC term.

this metric should capture the maximum value of a run's base peaks

What is the QC term's unit?

intensity / arbitrary

Value type

MS:4000003 ! single value

Describe any additional information.

  • this term is ID-free and can easily be calculated using all spectra (MS1 and MS2)
  • it is applicable to a single run
  • the value should be (relatively) constant for same / similar samples
@bittremieux
Copy link
Collaborator

There currently is MS:1000505 ! base peak intensity, so we should at least add a related relationship to that.

The difference here is that this would be the maximum base peak intensity across all spectra? Are MS1 and MS2 spectra comparable on this metric?

@julianu
Copy link
Collaborator Author

julianu commented Jan 10, 2025

In my understanding, there is no real consensus whether the base peak is calculated only by MS1/MS2 or by both. The maximum though is almost always originating from a MS1 (at least in the data we analysed).

So, yes, it would be the maximum of the MS:1000505 ! base peak intensity of all spectra.

@julianu
Copy link
Collaborator Author

julianu commented Jan 16, 2025

Recommended entry:

[Term]
id: MS:4000xyz
name: maximum base peak intensity
def: "This metric reflects the maximum base peak intensity (MS:1000505) of all spectra in a single run." [PSI:MS]
is_a: MS:4000003 ! single value
relationship: has_metric_category MS:4000009 ! ID free metric
relationship: has_metric_category MS:4000012 ! single run based metric
relationship: has_metric_category MS:4000015 ! multiple spectra based metric
relationship: has_value_type xsd:float ! The allowed value-type for this CV term
relationship: has_relation MS:1000505 ! base peak intensity

@bittremieux
Copy link
Collaborator

LGMT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants