From 061fe14e6c42b008c2868e9627336516fa788485 Mon Sep 17 00:00:00 2001
From: Doug Schrashun <dougschrashun@navapbc.com>
Date: Fri, 31 Jan 2025 10:34:07 -0500
Subject: [PATCH] add e2e test and fix some flakiness

---
 .../components/search/ExportSearchResultsButton.tsx |  5 ++++-
 frontend/tests/e2e/search/search-download.spec.ts   | 13 +++++++++++++
 frontend/tests/e2e/search/search.spec.ts            |  8 ++++----
 3 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 frontend/tests/e2e/search/search-download.spec.ts

diff --git a/frontend/src/components/search/ExportSearchResultsButton.tsx b/frontend/src/components/search/ExportSearchResultsButton.tsx
index c747c4f66..df6ffeff1 100644
--- a/frontend/src/components/search/ExportSearchResultsButton.tsx
+++ b/frontend/src/components/search/ExportSearchResultsButton.tsx
@@ -21,7 +21,10 @@ export function ExportSearchResultsButton() {
   }, [searchParams]);
 
   return (
-    <div className="flex-justify-start">
+    <div
+      className="flex-justify-start"
+      data-testid="search-download-button-container"
+    >
       <Button
         outline={true}
         type={"submit"}
diff --git a/frontend/tests/e2e/search/search-download.spec.ts b/frontend/tests/e2e/search/search-download.spec.ts
new file mode 100644
index 000000000..90b0cc50f
--- /dev/null
+++ b/frontend/tests/e2e/search/search-download.spec.ts
@@ -0,0 +1,13 @@
+import { expect, test } from "@playwright/test";
+
+test.describe("Search results export", () => {
+  test("should download a csv file when requested", async ({ page }) => {
+    const downloadPromise = page.waitForEvent("download");
+    await page.goto("/search");
+    await page
+      .locator('div[data-testid="search-download-button-container"] > button')
+      .click();
+    const download = await downloadPromise;
+    expect(download.url()).toBeTruthy();
+  });
+});
diff --git a/frontend/tests/e2e/search/search.spec.ts b/frontend/tests/e2e/search/search.spec.ts
index d472b124f..d99e7abad 100644
--- a/frontend/tests/e2e/search/search.spec.ts
+++ b/frontend/tests/e2e/search/search.spec.ts
@@ -54,10 +54,10 @@ test.describe("Search page tests", () => {
       "category-agriculture": "agriculture",
     };
 
-    await selectSortBy(page, "agencyDesc");
-
     await waitForSearchResultsInitialLoad(page);
 
+    await selectSortBy(page, "agencyDesc");
+
     if (project.name.match(/[Mm]obile/)) {
       await toggleMobileSearchFilters(page);
     }
@@ -156,12 +156,12 @@ test.describe("Search page tests", () => {
     page,
   }: PageProps) => {
     await page.goto("/search");
+    await waitForSearchResultsInitialLoad(page);
+
     await selectSortBy(page, "opportunityTitleDesc");
 
     await clickLastPaginationPage(page);
 
-    await waitForSearchResultsInitialLoad(page);
-
     const lastSearchResultTitle = await getLastSearchResultTitle(page);
 
     await selectSortBy(page, "opportunityTitleAsc");