Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbgrab doesn't handle rotation #15

Open
guijan opened this issue Jun 12, 2023 · 1 comment
Open

fbgrab doesn't handle rotation #15

guijan opened this issue Jun 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@guijan
Copy link

guijan commented Jun 12, 2023

The fb API does have this information: https://www.kernel.org/doc/Documentation/fb/api.txt (ctrl+F __u32 rotate;).
Rotated fbs are used in e.g. PostMarketOS running on Android devices.

Here's a screenshot that didn't have the rotation corrected:
test
To reproduce:

echo 3 > /sys/class/graphics/fbcon/rotate_all
fbgrab test.png
@GunnarMonell GunnarMonell added the enhancement New feature or request label Jun 30, 2023
@GunnarMonell
Copy link
Owner

Yes, true.

When I wrote fbgrab a long time ago I don't think that flag existed. I will look into adding it. I will mark this as an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guijan @GunnarMonell