From ecdb24df3cebe9bc27aa864712a47a4d81a0693e Mon Sep 17 00:00:00 2001
From: Marc Aldorasi <marc@groundctl.com>
Date: Mon, 12 Aug 2019 12:06:02 -0400
Subject: [PATCH] Link version.rc privately

---
 CMakeLists.txt | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c31dd550..6ca1f197 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -593,7 +593,7 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
                         DEFINE_SYMBOL "MZ_EXPORTS"
                         POSITION_INDEPENDENT_CODE 1)
 
-target_link_libraries(${PROJECT_NAME} ${version_rc})
+target_link_libraries(${PROJECT_NAME} PRIVATE ${version_rc})
 
 if(MZ_LZMA)
     set_target_properties(${PROJECT_NAME} PROPERTIES C_STANDARD 99)
@@ -601,33 +601,33 @@ endif()
 
 # Link with external libraries
 if(MZ_ZLIB AND NOT MZ_LIBCOMP)
-    target_link_libraries(${PROJECT_NAME} ${ZLIB_LIBRARIES})
+    target_link_libraries(${PROJECT_NAME} PUBLIC ${ZLIB_LIBRARIES})
     if(NOT ZLIB_FOUND)
         add_dependencies(${PROJECT_NAME} zlib)
     endif()
 endif()
 if(MZ_BZIP2 AND BZIP2_FOUND)
-    target_link_libraries(${PROJECT_NAME} ${BZIP2_LIBRARIES})
+    target_link_libraries(${PROJECT_NAME} PUBLIC ${BZIP2_LIBRARIES})
 endif()
 if(MZ_LIBCOMP)
-    target_link_libraries(${PROJECT_NAME} compression)
+    target_link_libraries(${PROJECT_NAME} PUBLIC compression)
 endif()
 if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN)
-    target_link_libraries(${PROJECT_NAME} ${Iconv_LIBRARIES})
+    target_link_libraries(${PROJECT_NAME} PUBLIC ${Iconv_LIBRARIES})
 endif()
 if(MZ_OPENSSL AND OPENSSL_FOUND)
-    target_link_libraries(${PROJECT_NAME} ${OPENSSL_LIBRARIES})
+    target_link_libraries(${PROJECT_NAME} PUBLIC ${OPENSSL_LIBRARIES})
 elseif(UNIX)
     if(APPLE AND NOT MZ_BRG)
         message(STATUS "Using CoreFoundation Framework")
         find_library(COREFOUNDATION_LIBRARY CoreFoundation)
-        target_link_libraries(${PROJECT_NAME} ${COREFOUNDATION_LIBRARY})
+        target_link_libraries(${PROJECT_NAME} PUBLIC ${COREFOUNDATION_LIBRARY})
         message(STATUS "Using Security Framework")
         find_library(SECURITY_LIBRARY Security)
-        target_link_libraries(${PROJECT_NAME} ${SECURITY_LIBRARY})
+        target_link_libraries(${PROJECT_NAME} PUBLIC ${SECURITY_LIBRARY})
         set_target_properties(${PROJECT_NAME} PROPERTIES LINK_FLAGS "-Wl,-F/Library/Frameworks")
     else()
-        target_link_libraries(${PROJECT_NAME} ${LIBBSD_LIBRARIES})
+        target_link_libraries(${PROJECT_NAME} PUBLIC ${LIBBSD_LIBRARIES})
     endif()
 endif()
 
@@ -656,7 +656,7 @@ if(MZ_BUILD_TEST)
     if(MZ_ZLIB AND NOT MZ_LIBCOMP)
         add_executable(minigzip_cmd "minigzip.c")
         set_target_properties(minigzip_cmd PROPERTIES OUTPUT_NAME minigzip)
-        target_link_libraries(minigzip_cmd ${PROJECT_NAME})
+        target_link_libraries(minigzip_cmd PUBLIC ${PROJECT_NAME})
 
         if(NOT SKIP_INSTALL_BINARIES AND NOT SKIP_INSTALL_ALL)
             install(TARGETS minigzip_cmd RUNTIME DESTINATION "bin")
@@ -665,7 +665,7 @@ if(MZ_BUILD_TEST)
 
     add_executable(minizip_cmd "minizip.c" "test/test.c" "test/test.h")
     set_target_properties(minizip_cmd PROPERTIES OUTPUT_NAME ${PROJECT_NAME})
-    target_link_libraries(minizip_cmd ${PROJECT_NAME})
+    target_link_libraries(minizip_cmd PUBLIC ${PROJECT_NAME})
 
     if(NOT SKIP_INSTALL_BINARIES AND NOT SKIP_INSTALL_ALL)
         install(TARGETS minizip_cmd RUNTIME DESTINATION "bin")
@@ -804,14 +804,14 @@ if(MZ_BUILD_FUZZ_TEST)
 
     if (CMAKE_C_COMPILER_ID STREQUAL "Clang")
         enable_language(CXX)
-        target_link_libraries(zip_fuzzer "FuzzingEngine")
+        target_link_libraries(zip_fuzzer PUBLIC "FuzzingEngine")
         set_target_properties(zip_fuzzer PROPERTIES LINKER_LANGUAGE CXX)
-        target_link_libraries(unzip_fuzzer "FuzzingEngine")
+        target_link_libraries(unzip_fuzzer PUBLIC "FuzzingEngine")
         set_target_properties(unzip_fuzzer PROPERTIES LINKER_LANGUAGE CXX)
     endif()
 
-    target_link_libraries(zip_fuzzer ${PROJECT_NAME})
-    target_link_libraries(unzip_fuzzer ${PROJECT_NAME})
+    target_link_libraries(zip_fuzzer PUBLIC ${PROJECT_NAME})
+    target_link_libraries(unzip_fuzzer PUBLIC ${PROJECT_NAME})
 
     if(NOT SKIP_INSTALL_BINARIES AND NOT SKIP_INSTALL_ALL)
         install(TARGETS zip_fuzzer RUNTIME DESTINATION "bin")