Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVSError: Cannot yet support not keyword with test functions. #23

Open
LukeLavan opened this issue Oct 11, 2023 · 0 comments
Open

EVSError: Cannot yet support not keyword with test functions. #23

LukeLavan opened this issue Oct 11, 2023 · 0 comments

Comments

@LukeLavan
Copy link
Contributor

LukeLavan commented Oct 11, 2023

See relevant line in evs.py

The TODO comment aboves gives some hint that the EMEDF_TESTS dict should contain a 'negate' key - I'm assuming keyed with the negated test's node.id and valued with the corresponding instruction (ie, if node.id is 'PlayerHasWeapon' and negate is true, then do tests = tests['negate'] which returns {'if': 'IfPlayerDoesNotHaveWeapon'}). If the 'negate' key doesn't exist, throw NoNegateError which would then be resolved with a temporary condition by the caller here (ie, if node.id is 'PlayerInCovenant' and negate is true, then throw NoNegateError since there's no corresponding negated instruction).

Is my understanding correct and am I missing something? This is a feature that was working before so it'd be helpful to have working again. I'll try the above approach and report back the results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant