Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe fixes #1713

Merged
merged 8 commits into from
Sep 24, 2023
Merged

Pipe fixes #1713

merged 8 commits into from
Sep 24, 2023

Conversation

brachy84
Copy link
Contributor

@brachy84 brachy84 commented Apr 16, 2023 •
edited
Loading

What

Implementation Details

Outcome

fixes and microoptimizations

Additional Information

Potential Compatibility Issues

@brachy84 brachy84 added type: bug Something isn't working type: refactor Suggestion to refactor a section of code labels Apr 16, 2023
TechLord22
TechLord22 reviewed Apr 16, 2023
View reviewed changes
Copy link
Member

@TechLord22 TechLord22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that with these changes, item pipe endpoints no longer tick. Individual pipe segments and endpoints with covers requiring ticking do still tick, correct?

@brachy84
Copy link
Contributor Author

You mentioned that with these changes, item pipe endpoints no longer tick. Individual pipe segments and endpoints with covers requiring ticking do still tick, correct?

Thats correct.

@ALongStringOfNumbers ALongStringOfNumbers added this to the 2.6.2 milestone Apr 17, 2023
@brachy84
Copy link
Contributor Author

This might not fix #1219. I just added an earlier check, so nothing will ever get printed.

@TechLord22 TechLord22 modified the milestones: 2.6.2, 2.7 May 2, 2023
@serenibyss serenibyss modified the milestones: 2.7, 2.8 Jul 6, 2023
@brachy84 brachy84 requested a review from a team as a code owner August 31, 2023 17:01
@TechLord22 TechLord22 changed the base branch from master to 2.8 September 24, 2023 06:37
@TechLord22 TechLord22 merged commit b58dc7b into 2.8 Sep 24, 2023
@TechLord22 TechLord22 deleted the br-pipe-fix branch September 24, 2023 06:44
serenibyss pushed a commit that referenced this pull request Oct 31, 2023
@brachy84 @serenibyss
Pipe fixes (#1713)
5884888
serenibyss pushed a commit that referenced this pull request Oct 31, 2023
@brachy84 @serenibyss
Pipe fixes (#1713)
ca2e32e
serenibyss pushed a commit that referenced this pull request Nov 23, 2023
@brachy84 @serenibyss
Pipe fixes (#1713)
14a906b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tictim Tictim Tictim left review comments

@TechLord22 TechLord22 TechLord22 approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

Item Pipe becomes null
5 participants
@brachy84 @Tictim @TechLord22 @serenibyss @ALongStringOfNumbers