Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ItemKept in ItemsKeptOnDeath #563

Open
GregHib opened this issue Dec 9, 2024 · 0 comments
Open

Apply ItemKept in ItemsKeptOnDeath #563

GregHib opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@GregHib
Copy link
Owner

GregHib commented Dec 9, 2024

Items ItemKept don't currently apply to the kept on death algorithm meaning items marked as always saved aren't always saved, or wilderness lost one's are always lost etc...

Probably worth renaming?

  • ShouldKeep
  • ShouldKeepItem
  • KeepItem
  • KeepType
  • KeptItemType

ItemKept.Wilderness should also be inverted. i.e. ItemKept.OutsideWilderness

@GregHib GregHib added the bug Something isn't working label Dec 9, 2024
@GregHib GregHib changed the title Apply ItemKept in ItemsKeptOnDeath alg Apply ItemKept in ItemsKeptOnDeath Dec 9, 2024
GregHib added a commit to jarryd229/void that referenced this issue Dec 9, 2024
GregHib added a commit that referenced this issue Dec 9, 2024
* Restless Ghost quest

* Update FatherAereck.kts

* Update LumbridgeChurch.kts

* Formatting, better object names, fix church bell

* Add quest start interface

* Spawn only one restless ghost

* Add skeleton warlock

* Add temp fix for losing skull on death #563

* Fix npc combat attack errors

* Fix trapdoor opening

* Fix level up skill stat flash

* Add force exit cutscene handling

* Remove duplicate cutscene ghost indexing

---------

Co-authored-by: GregHib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant