New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Element1D and Element2D for methods that could be moved to their parent class #6

Open

Greg-Hamel opened this issue Jun 27, 2017 · 0 comments

Assignees

Labels

Owner

Greg-Hamel commented Jun 27, 2017

A few methods in both Element1D and Element2D look alike, if they are not the same.

Two things can be done in order to optimize this:

Generalize both methods, make them behave the same way and move them to the parent class (Element)
Move them to the parent class directly if they are the exact same.

Greg-Hamel added the enhancement label

Greg-Hamel self-assigned this

Greg-Hamel mentioned this issue

Make all variable the same for both Element1D and Element2D #7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment