You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your test only covers the behavior of the buildCustomMessage method. What I'm saying is that buildCustomMessage throws a PermanentEventNotificationException which then gets caught by the try/catch block in execute and replaced with a TemporaryEventNotificationException. If you believe it is right to throw a PermanentEventNotificationException here, then your try/catch block in execute should specifically catch PermanentEventNotificationException and re-throw it rather than wrapping it in a TemporaryEventNotificationException.
Your test only covers the behavior of the
buildCustomMessage
method. What I'm saying is thatbuildCustomMessage
throws aPermanentEventNotificationException
which then gets caught by the try/catch block inexecute
and replaced with aTemporaryEventNotificationException
. If you believe it is right to throw aPermanentEventNotificationException
here, then your try/catch block inexecute
should specifically catchPermanentEventNotificationException
and re-throw it rather than wrapping it in aTemporaryEventNotificationException
.Originally posted by @waab76 in #595 (comment)
The text was updated successfully, but these errors were encountered: