Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unit test for build custom message #610

Open
lingpri opened this issue Oct 26, 2020 · 0 comments
Open

update unit test for build custom message #610

lingpri opened this issue Oct 26, 2020 · 0 comments
Assignees

Comments

@lingpri
Copy link
Contributor

lingpri commented Oct 26, 2020

Your test only covers the behavior of the buildCustomMessage method. What I'm saying is that buildCustomMessage throws a PermanentEventNotificationException which then gets caught by the try/catch block in execute and replaced with a TemporaryEventNotificationException. If you believe it is right to throw a PermanentEventNotificationException here, then your try/catch block in execute should specifically catch PermanentEventNotificationException and re-throw it rather than wrapping it in a TemporaryEventNotificationException.

Originally posted by @waab76 in #595 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant