Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement extending, joining, and creating new subpaths with the Spline tool #2203

Merged
merged 21 commits into from
Jan 25, 2025
Merged

Implement extending, joining, and creating new subpaths with the Spline tool #2203

merged 21 commits into from
Jan 25, 2025

Conversation

indierusty
Copy link
Contributor

@indierusty indierusty commented Jan 18, 2025 •
edited by Keavon
Loading

  1. Visualize endpoints of paths.
  2. Extend endpoints of paths.
  3. Join endpoint of the paths.
  4. Create new path in the same layer / currently selected layer.
  5. Enable snapping of endpoints for joining. It works even if regular snapping is disabled.

Closes #2184, part 2

@indierusty indierusty changed the title Allow user to extend, join and create new paths using spline tool Implemented extending, joining and creating new paths using spline tool Jan 18, 2025
@Keavon
Copy link
Member

Keavon commented Jan 18, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 8889a64
https://926e72b6.graphite.pages.dev

@Keavon Keavon changed the title Implemented extending, joining and creating new paths using spline tool Implement extending, joining, and creating new subpaths with the Spline tool Jan 19, 2025
@Keavon
Copy link
Member

Keavon commented Jan 19, 2025

Marking as draft for the moment until snapping to endpoints is added per Discord discussion.

@Keavon Keavon marked this pull request as draft January 19, 2025 04:05
@indierusty indierusty marked this pull request as ready for review January 19, 2025 14:30
@indierusty indierusty marked this pull request as draft January 20, 2025 08:15
@indierusty indierusty marked this pull request as ready for review January 20, 2025 10:19
@indierusty indierusty marked this pull request as draft January 20, 2025 16:59
@indierusty indierusty marked this pull request as ready for review January 21, 2025 06:34
@Keavon
Copy link
Member

Keavon commented Jan 24, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 0bc30dd
https://a43a6290.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 24, 2025 •
edited
Loading

Code review feedback for you in narrated video form: https://files.keavon.com/-/PunyUprightStagbeetle/capture_35_.mp4

A lot of that is rather advanced. Let's worry just about fixing the actual bugs I identified in the video, and save the complex multi-layer handling for another PR. I'm marking this as a draft for the moment while awaiting the bug fixes. Please mark it as ready for review once you have a fix. Thanks!

@Keavon Keavon mentioned this pull request Jan 24, 2025
Open
4 tasks
@Keavon Keavon marked this pull request as draft January 24, 2025 01:51
@indierusty
Copy link
Contributor Author

That bug was actually intended behavior. I misunderstood as my thinking was that extending the path was supposed to be initiated by dragging. I now understand that it should be done by clicking to extend and then clicking again to insert the extended point, followed by normal insertion. I will fix it.

@indierusty indierusty marked this pull request as ready for review January 25, 2025 05:33
@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for acd4ec4
https://d703a156.graphite.pages.dev

@GraphiteEditor GraphiteEditor deleted a comment from github-actions bot Jan 25, 2025
@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

  • Shift isn't in the hints bar for adding to the subpath, this should match how other tools show it
  • Bug: after connecting two subpath endpoints together, if I go click on another subpath endpoint, it doesn't extend and instead creates a whole new spline layer. But it seems to be intermittent. Video

@Keavon Keavon marked this pull request as draft January 25, 2025 06:42
@indierusty indierusty marked this pull request as ready for review January 25, 2025 08:38
@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 49334a4
https://795c06b2.graphite.pages.dev

Keavon
Keavon reviewed Jan 25, 2025
View reviewed changes
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
editor/src/messages/tool/tool_messages/spline_tool.rs Outdated Show resolved Hide resolved
@Keavon Keavon enabled auto-merge (squash) January 25, 2025 11:15
@Keavon Keavon merged commit f7b7f6b into GraphiteEditor:master Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the Spline tool draw a polylines with a Path -> Spline from Points node setup
2 participants
@indierusty @Keavon