Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of optionals as return type of BufferingSystem::get_data #34

Open
Victor-C-Zhang opened this issue Nov 8, 2021 · 0 comments
Labels
question Further information is requested

Comments

@Victor-C-Zhang
Copy link
Collaborator

The current pattern bool get_data(data_ret_t& data) is non-idiomatic. In an ideal code style world, we should be returning optionals. But to do so we should investigate the performance difference between the two methods and resolve the issue of introducing a duplicate dependency on Boost in both the buffering and streaming repos.

Evan:

Yeah but avoiding multiple installations of the same dependency is for some reason non-trivial. For instance we have to install gtest twice.

@Victor-C-Zhang Victor-C-Zhang added the question Further information is requested label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant