Feature request: Select All

[oleg68]

Please add a capability to select the whole text window content with pressing Ctrl+A as like other applications do.

Also if some text is already selected, paste from clipboard should replace the selected text with the clipboard content. But now the text from clipboaard is added instead of replacing. It would be better to fix it.

[eturpault]

What you are requesting is already working like this in Windows (I use the Tkinter GUI framework). It seems that Tkinter is not behaving in the same way in Linux. According to what I see in some forums it has to be implemented manually. I will do it.

[eturpault]

It is implemented for OdfEdit v2.5.
Here is a beta release with this fix (and the drag&drop feature as well).
OdfEdit-2.5beta1.zip

[oleg68]

@eturpault I'm starting to test OdfEdit-2.5 beta now.

I'll put my notes here.

[oleg68]

1. The drag-and-drop capability is great, thank you. But I'm able to select only one rank i a time. I'd like to have a capability to select several ranks in a time and move them to another windchest at once.

[eturpault]

Yes it would be good to have the possiblity to move several objects at the same time, I tried to implement it but I encountered issues. In the objects tree if one selects several items, the childs of the selected objects are selected as well, even if they are not visible, which is not good. Probably it should be possible to select and drag multiple objects from the objects list only, I will try to make it possible (only if all the selected objects are of the same type). Else objects moving is not an operation done often and there are never a lot of objects to move, moving one by one takes a reasonable time.

[oleg68]

2. When I add a windchest with the Add button, an invalid empty windchest appears:

[WindchestGroup013]
Name=WindchestGroup template
NumberOfEnclosures=0
Enclosure001=
NumberOfTremulants=0
Tremulant001=

I'd not put Enclosure001= and Tremulant001= here.

[eturpault]

Yes there are certainly improvements to do in my templates, I will integrate this one. They can be modified in the file GoObjectsTemplates.txt located in the folder resources. If you see other improvements to do, with the experience that you have, feel free to modify this file and share it to me, thank you.

[oleg68]

3. When converting a Erfurt Predigerkirche (demo) from hauptwerk to odf, I receive

[Rank034]
Name=105. P  Pommer 4' (front) UNUSED
...
Pipe029PitchTuning=203
...
Pipe031PitchTuning=403
...
Pipe032PitchTuning=203

I doubt that 203, 403, 203 are correct. I expect 200, 400, 200.

[eturpault]

Ok clear, thanks. So I am already calculating the pitch tuning as you recommand (i.e. comparing the cents of the two pipes) but doing it in a different way : log2(X)-log2(Y) instead of log2(X/Y) [ not log2(X*Y) ].
I have changed my code to use your formula, it is more optimized.

Pipe029PitchTuning = 1200 * log2( (651.76357844136 / 435) / (579.59 / 435) ) = 203

[oleg68]

Dividing by 435 is not necessary: (a/c)/(b/c) = a/b

[eturpault]

You are right, even simpler formula.

[oleg68]

But 435 should be converted to the organ level PitchCorrection value: 1200 * log2(435/440)

[eturpault]

Done. Now OdfEdit will make right pitch conversion at organ and pipes levels. Thanks.

[oleg68]

4. There is a Search in ODF window. But sometimes it is necessary to search in the current section only. By example, search all 'PipeXXXPitchTuning` occurences.

[eturpault]

In the search results list, at the beginning of each line there is the section name, and the results are sorted by section name, so you can easily see together in the list all the occurences of the searched text of the same section. Is it what you need ? Else I have misunderstood your comment.

[oleg68]

5. A capability of Find and Replace is higly desired (for the current section, for all subobjects of the current or for the all ODF). For example, replace all occurences ..\OrganInstallationPackages\002524\ to pipes/erfurt/.

[eturpault]

Good idea, I will add it.

[kerkovits]

Regex possibility for search&reaplace would definitely be a good option for more complex use cases, if it is not a large overhead.

[eturpault]

Python has a dedicated module to manage Regex expressions, so it should not be difficult to use Regex in OdfEdit search&replace functions, I will try to use it.

[eturpault]

I pushed a new version 2.5beta2 of OdfEdit.py in the branch v2.5_beta with the implementation of the improved search function (regular expression support, search range selection) and the addition of the replace feature. There is also the improvement of the PitchTuning calculation discussed with Oleg.
I can provide the Linux executable if someone wants it rather than the .py file.