View sample file details failure on FreeBSD

[kwhite-uottawa]

I get a "Not a RIFF file or a wavpack file." when using the View sample file details menu when running a GoOdf executable built on FreeBSD. As far as I can tell, this is due to char fourCBuffer[4] in WAVfileParser.cpp not necessarily being null terminated when being compared with IsSameAs().

The attached patch fixes the issue for me.
WAVfileParser.txt

[larspalo]

Thanks for reporting. I dug a little in this issue and it indeed seems to be an issue also for the windows build. However, just using:

char fourCBuffer[5] = {};

in all declarations seems to be enough to fix it as it's then implicitly zeroed which means that there will always be a zero (null) at the end after four chars are read into it. Could you please test this patch WAVfileParserChange.zip on FreeBSD and report if that works.

[kwhite-uottawa]

Tested successfully. Yes, your patch also fixes the issue on FreeBSD.

[larspalo]

This issue should have been fixed with commit 7505610 and, even if is not yet included in any release, intermediate builds can be found at https://github.com/GrandOrgue/GoOdf/actions/runs/10716356672 for those who doesn't build from source.