Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run/websockets tests appear to be broken by a dependency on a GCR image #3827

Closed
briandorsey opened this issue Sep 4, 2024 · 2 comments
Closed

build: run/websockets tests appear to be broken by a dependency on a GCR image #3827

briandorsey opened this issue Sep 4, 2024 · 2 comments
Assignees
@subfuzion
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@briandorsey
Copy link
Member

While attempting to disable flaky-bot in #3822, tests for run/websockets are now failing with a permissions error.

After troubleshooting (thanks @subfuzion !), it appears that test is relying on a base image hosted in GCR which has recently been deprecated.
@briandorsey briandorsey added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 4, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 4, 2024
@briandorsey briandorsey mentioned this issue Sep 4, 2024
Merged
10 tasks
@subfuzion subfuzion mentioned this issue Sep 5, 2024
Closed
@subfuzion
Copy link
Contributor

I was able to make a fix, but not an optimal one; the internal decision was made to temporarily disable run/websockets testing (b/366619034), merged with #3853.

@subfuzion
Copy link
Contributor

Testing is now blocked on run/markdown-preview. See: #3857.

@iennae iennae closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subfuzion subfuzion

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(run): diagnose run/websockets CI GoogleCloudPlatform/nodejs-docs-samples
3 participants
@briandorsey @subfuzion @iennae