Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/browsing_context/test_navigate_events.py::test_scriptNavigate_checkEvents is flaky #2900

Open
OrKoN opened this issue Dec 16, 2024 · 1 comment

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Dec 16, 2024

See https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/12352754819/job/34470461604?pr=2897#step:11:563

FAILED tests/browsing_context/test_navigate_events.py::test_scriptNavigate_checkEvents - AssertionError: assert equals failed
  [                                list([                          
    {                                dict({                        
      'method': 'script.message',      'method': 'script.message', 
      'params': {                      'params': dict({            
        'channel': 'beforeunload_        'channel': 'beforeunload_ 
  channel',                        channel',                       
        'data': {                        'data': dict({            
          'type': 'string',                'type': 'string',       
          'value': 'beforeunload'          'value': 'beforeunload' 
  ,                                ,                               
        },                               }),                       
        'source': {                      'source': dict({          
          'context': 'stable_0',           'context': 'stable_0',  
          'realm': '-759880046197                                  
  8052412.4746192021910511488',                                    
        },                               }),                       
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
      'method': 'browsingContext.      'method': 'browsingContext. 
  navigationStarted',              navigationStarted',             
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'navigation': 'stable_1',        'navigation': 'stable_1', 
        'timestamp': 173435263736                                  
  4,                                                               
        'url': 'stable_2',               'url': 'stable_2',        
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
      'method': 'network.beforeRe      'method': 'network.beforeRe 
  questSent',                      questSent',                     
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'initiator': {                                             
          'type': 'other',                                         
        },                                                         
        'isBlocked': False,              'isBlocked': False,       
        'navigation': 'stable_1',        'navigation': 'stable_1', 
        'redirectCount': 0,              'redirectCount': 0,       
        'request': 'stable_4',           'request': 'stable_4',    
        'timestamp': 173435263736                                  
  4,                                                               
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
      'method': 'browsingContext.      'method': 'browsingContext. 
  navigationStarted',              navigationStarted',             
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'navigation': 'stable_5',        'navigation': 'stable_5', 
        'timestamp': 173435263740                                  
  2,                                                               
        'url': 'stable_6',               'url': 'stable_6',        
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
      'method': 'browsingContext.      'method': 'network.beforeRe 
  navigationAborted',              questSent',                     
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'navigation': 'stable_1',                                  
        'timestamp': 173435263741                                  
  6,                                                               
        'url': 'stable_2',                                         
      },                                                           
      'type': 'event',                                             
    },                                                             
    {                                                              
      'error': 'unknown error',                                    
      'id': 'stable_7',                                            
      'message': 'navigation canc                                  
  eled by concurrent navigation',                                  
      'stacktrace': 'Error\n    a                                  
  t new UnknownErrorException (<a                                  
  nonymous>:347:43)\n    at Brows                                  
  ingContextImpl.navigate (<anony                                  
  mous>:6[573](https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/12352754819/job/34470461604?pr=2897#step:11:574):27)\n    at async #p                                  
  rocessCommand (<anonymous>:4615                                  
  :28)\n    at async CommandProce                                  
  ssor.processCommand (<anonymous                                  
  >:4742:32)',                                                     
      'type': 'error',                                             
    },                                                             
    {                                                              
      'method': 'network.beforeRe                                  
  questSent',                                                      
      'params': {                                                  
        'context': 'stable_0',                                     
        'initiator': {                                             
          'stackTrace': {                                          
            'callFrames': [                                        
              {                                                    
                'columnNumber': 1                                  
  36,                                                              
                'functionName': '                                  
  ',                                                               
                'lineNumber': 0,                                   
                'scriptId': '10',                                  
                'url': 'stable_2'                                  
  ,                                                                
              },                                                   
            ],                                                     
          },                                                       
          'type': 'script',                                        
        },                                                         
        'isBlocked': False,              'isBlocked': False,       
        'navigation': 'stable_5',        'navigation': 'stable_5', 
        'redirectCount': 0,              'redirectCount': 0,       
        'request': 'stable_9',           'request': 'stable_8',    
        'timestamp': 1734352[637](https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/12352754819/job/34470461604?pr=2897#step:11:638)40                                  
  1,                                                               
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
                                       'method': 'browsingContext. 
                                   navigationAborted',             
                                       'params': dict({            
                                         'context': 'stable_0',    
                                         'navigation': 'stable_1', 
                                         'url': 'stable_2',        
                                       }),                         
                                       'type': 'event',            
                                     }),                           
                                     dict({                        
                                       'error': 'unknown error',   
                                       'id': 'stable_9',           
                                       'type': 'error',            
                                     }),                           
                                     dict({                        
      'method': 'browsingContext.      'method': 'browsingContext. 
  domContentLoaded',               domContentLoaded',              
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'navigation': 'stable_5',        'navigation': 'stable_5', 
        'timestamp': 173435263742                                  
  3,                                                               
        'url': 'stable_6',               'url': 'stable_6',        
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
    {                                dict({                        
      'method': 'browsingContext.      'method': 'browsingContext. 
  load',                           load',                          
      'params': {                      'params': dict({            
        'context': 'stable_0',           'context': 'stable_0',    
        'navigation': 'stable_5',        'navigation': 'stable_5', 
        'timestamp': 173435263742                                  
  4,                                                               
        'url': 'stable_6',               'url': 'stable_6',        
      },                               }),                         
      'type': 'event',                 'type': 'event',            
    },                               }),                           
  ]                                ])
======= 1 failed, 115 passed, 2 skipped, 1 xfailed in 164.18s (0:02:44) ========
(run-e2e.mjs)
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 16, 2024

cc @sadym-chromium

sadym-chromium added a commit that referenced this issue Dec 17, 2024
Address #2900

+ remove extra `await` and `async` from unit tests
sadym-chromium added a commit that referenced this issue Dec 17, 2024
Address #2900

+ remove extra `await` and `async` from unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant