Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match type does not show in search by uuid #90

Open
dimus opened this issue Nov 1, 2016 · 2 comments
Open

Match type does not show in search by uuid #90

dimus opened this issue Nov 1, 2016 · 2 comments
Labels
bug

Comments

@dimus
Copy link
Member

dimus commented Nov 1, 2016 •
edited
Loading

http://gnresolver.globalnames.org/api/name_strings/00015aa4-233c-574b-94ea-acd00962c2e0
returns

...
vernacular: [ ],
kind: "None",
dataSourceTitle: "NCBI",
...

kind is hard to understand matchType would be better. And it should return type of a match.
@dimus dimus added the bug label Nov 1, 2016
@alexander-myltsev
Copy link
Contributor

And what is matchType can be? ExactNameMatchByUUID or ExactCanonicalNameMatchByUUID I suppose?

@alexander-myltsev
Copy link
Contributor

Make matchType to UUIDLookup

alexander-myltsev added a commit that referenced this issue Nov 9, 2016
@alexander-myltsev
#90: rename kind to matchType
91134f1
alexander-myltsev added a commit that referenced this issue Nov 9, 2016
@alexander-myltsev
#90: Change findNameStringByUuid match type to UUIDLookup
6f49c25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimus @alexander-myltsev