Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for inp import files (ud-ws) #902

Open
xtorret opened this issue Nov 20, 2023 · 2 comments
Open

Refactor for inp import files (ud-ws) #902

xtorret opened this issue Nov 20, 2023 · 2 comments
Assignees
@pahbloo @smaspons
Labels
python Refactor sql

Comments

@xtorret
Copy link
Member

xtorret commented Nov 20, 2023 •
edited
Loading

Import inp file has lower performance among complex anidation againts vi_ views, triggers and functions.
The goal of this refactor is:

  • Remove dependences from vi_ views
  • Enhance performance by using direct inserts into databases without loops
  • Unify import code in one unique function, removing trigger function for views
  • Clean code removing trigger and vi_ views (are not longer used for export inp process)
@jcpiriou
Copy link

Hi Xavier. What is the goal of this refactor?

@xtorret
Copy link
Member Author

xtorret commented Nov 21, 2023

Hi Jcpiriou, I have detailed on the issue
Thanks for your feedback

@pahbloo pahbloo self-assigned this May 2, 2024
@smaspons smaspons self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pahbloo pahbloo

@smaspons smaspons

Labels
python Refactor sql
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue-902 Giswater/giswater_qgis_plugin
4 participants
@xtorret @pahbloo @jcpiriou @smaspons