Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-209] Update stream-android-push to v1.3.0. #1290

Merged
merged 4 commits into from
Jan 23, 2025
Merged

[AND-209] Update stream-android-push to v1.3.0. #1290

merged 4 commits into from
Jan 23, 2025

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

Update the stream-android-push library to v1.3.0.

🛠 Implementation details

  • Update stream-android-push to v1.3.0
  • Change PushDelegateProvider declaration to AndroidPushDelegateProvider in AndroidManifest
  • Update VideoPushDelegate implementation to match what is expected by AndroidPushDelegateProvider
  • Update StreamNotificationManager implementation to match PushDelegate changes
  • Update creation of FirebasePushDeviceGenerator in sample apps - pass Context via constructor
  • Update consumer-proguard-rules.pro with AndroidPushDelegateProvider instead of PushDelegateProvider

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.07 MB 11.20 MB 0.13 MB 🟢
stream-video-android-ui-xml 5.80 MB 5.66 MB -0.13 MB 🚀
stream-video-android-ui-compose 5.79 MB 5.80 MB 0.01 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review January 22, 2025 17:41
@VelikovPetar VelikovPetar requested a review from a team as a code owner January 22, 2025 17:41
JcMinarro
JcMinarro reviewed Jan 22, 2025
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
skydoves
skydoves approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 0266410 into develop Jan 23, 2025
8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/update-stream-push-to-v130 branch January 23, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

@JcMinarro JcMinarro JcMinarro left review comments

@liviu-timar liviu-timar liviu-timar approved these changes

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VelikovPetar @JcMinarro @aleksandar-apostolov @skydoves @liviu-timar