Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-258] Bump stream-log version #1288

Merged

Conversation

liviu-timar
Copy link
Member

🎯 Goal

Update to latest stream-log version.

🛠 Implementation details

Describe the implementation

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Before After

🧪 Testing

Explain how this change can be tested (or why it can't be tested)

Provide a patch below if it is necessary for testing

Provide the patch summary here
Provide the patch code here

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@liviu-timar liviu-timar requested a review from a team as a code owner January 20, 2025 16:53
@liviu-timar liviu-timar requested a review from skydoves January 20, 2025 16:55
@liviu-timar liviu-timar force-pushed the and-258-align-versions-for-stream-android-log branch from e90a84f to 5963257 Compare January 20, 2025 20:13
Copy link
Contributor

github-actions bot commented Jan 20, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 10.94 MB 11.07 MB 0.13 MB 🟢
stream-video-android-ui-xml 5.80 MB 5.80 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.79 MB 5.79 MB 0.00 MB 🟢

Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aleksandar-apostolov aleksandar-apostolov merged commit e17a03e into develop Jan 21, 2025
8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the and-258-align-versions-for-stream-android-log branch January 21, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants