Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-260] Use legacy call config when it's passed and the new registry config is not #1287

Merged
merged 12 commits into from
Jan 23, 2025
Merged

[AND-260] Use legacy call config when it's passed and the new registry config is not #1287

merged 12 commits into from
Jan 23, 2025

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Jan 20, 2025 •
edited
Loading

🎯 Goal

Use deprecated callServiceConfig parameter in Builder as fallback.

@liviu-timar liviu-timar requested a review from a team as a code owner January 20, 2025 15:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.07 MB 11.07 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.80 MB 5.80 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.79 MB 5.79 MB 0.00 MB 🟢

@liviu-timar liviu-timar force-pushed the and-260-use-legacy-call-config branch from eb9fb40 to dd9ce0a Compare January 20, 2025 15:46
@liviu-timar liviu-timar changed the title [AND-260] Use deprecated call config [AND-260] Use legacy call config when it's passed and the new config is not Jan 21, 2025
@liviu-timar liviu-timar force-pushed the and-260-use-legacy-call-config branch from 0d60ba7 to 94c6c31 Compare January 22, 2025 16:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@liviu-timar liviu-timar changed the title [AND-260] Use legacy call config when it's passed and the new config is not [AND-260] Use legacy call config when it's passed and the new registry config is not Jan 23, 2025
@aleksandar-apostolov aleksandar-apostolov merged commit fd4d04f into develop Jan 23, 2025
8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the and-260-use-legacy-call-config branch January 23, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviu-timar @aleksandar-apostolov