Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Implement SonarCloud #1275

Merged
merged 4 commits into from
Jan 10, 2025
Merged

[CI] Implement SonarCloud #1275

merged 4 commits into from
Jan 10, 2025

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Jan 8, 2025

🎯 Goal

Resolve https://linear.app/stream/issue/AND-214

🎯 Goal

🛠 Implementation details

  • Use Kover to get test coverage
  • Use SonarQube gradle plugin to upload test coverage to SonarCloud

🎨 UI Changes

Screenshot 2025-01-09 at 9 55 15 AM

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

gif

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@testableapple testableapple force-pushed the ci/sonar-cloud branch 2 times, most recently from a8bb4cf to 05873bf Compare January 8, 2025 21:57
@testableapple testableapple marked this pull request as ready for review January 9, 2025 09:58
@testableapple testableapple requested a review from a team as a code owner January 9, 2025 09:58
@testableapple testableapple changed the title [WIP][CI] Implement SonarCloud [CI] Implement SonarCloud Jan 9, 2025
@testableapple testableapple force-pushed the ci/sonar-cloud branch 4 times, most recently from 31c6de5 to c209688 Compare January 9, 2025 15:50
Copy link

sonarqubecloud bot commented Jan 9, 2025

@testableapple testableapple enabled auto-merge (squash) January 10, 2025 13:57
@aleksandar-apostolov aleksandar-apostolov merged commit c5db8fa into develop Jan 10, 2025
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the ci/sonar-cloud branch January 10, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants